Skip to content

PR Validation - allow insertion to run on commit that isn't latest #77369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akhera99 merged 6 commits into from
Feb 28, 2025
Merged

PR Validation - allow insertion to run on commit that isn't latest #77369

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ea04329
allow insertion to run on commit that isn't latest
akhera99 Feb 27, 2025
8010f86
remove comments
akhera99 Feb 27, 2025
fdb84ff
Allow PR Val pipeline runs to opt-out of the latest commit validation
JoeRobich Feb 28, 2025
c503064
Update CI excludes paths to include some yml files
JoeRobich Feb 28, 2025
d69c175
Update setup-pr-validation.ps1
akhera99 Feb 28, 2025
f67bdcd
Apply suggestions from code review
JoeRobich Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions eng/setup-pr-validation.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,19 @@ try {
$remoteRef = git ls-remote origin refs/pull/$prNumber/head
Write-Host ($remoteRef | Out-String)

$prHeadSHA = $remoteRef.Split()[0]
if (!$prHeadSHA.StartsWith($commitSHA)) {
Write-Host "##vso[task.LogIssue type=error;]The PR's Head SHA ($prHeadSHA) does not begin with the specified commit SHA ($commitSHA). Unreviewed changes may have been pushed to the PR."
exit 1
}

Write-Host "Setting up the build for PR validation by merging refs/pull/$prNumber/merge into $sourceBranchName..."
git pull origin refs/pull/$prNumber/merge
if (!$?) {
Write-Host "##vso[task.LogIssue type=error;]Merging branch refs/pull/$prNumber/merge failed."
exit 1
}

Write-Host "Checking out the specified commit SHA ($commitSHA)..."
git checkout $commitSHA
if (!$?) {
Write-Host "##vso[task.LogIssue type=error;]Checking out commit SHA $commitSHA failed."
exit 1
}
}
catch {
Write-Host $_
Expand Down
Loading