Skip to content

Only refetch from CWT if adding to it failed #77211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyrusNajmabadi merged 1 commit into from
Feb 13, 2025
Merged

Only refetch from CWT if adding to it failed #77211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...otocol/Features/Diagnostics/EngineV2/DiagnosticIncrementalAnalyzer_IncrementalAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ public async Task<ImmutableArray<DiagnosticData>> ForceAnalyzeProjectAsync(Proje
// Try to add the new computed data to the CWT. But use any existing value that another thread
// might have beaten us to storing in it.
#if NET
_projectToForceAnalysisData.TryAdd(project, box);
Contract.ThrowIfFalse(_projectToForceAnalysisData.TryGetValue(project, out box));
if (!_projectToForceAnalysisData.TryAdd(project, box))
Contract.ThrowIfFalse(_projectToForceAnalysisData.TryGetValue(project, out box));
#else
box = _projectToForceAnalysisData.GetValue(project, _ => box);
#endif
Expand Down
Loading