Skip to content

Use the new test framework for missing IDE0060 diagnostics #77158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sharwell merged 5 commits into from
Feb 12, 2025
Merged

Use the new test framework for missing IDE0060 diagnostics #77158

sharwell merged 5 commits into from
Feb 12, 2025

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented Feb 11, 2025 •
edited
Loading

Also fixes a regression where writes to a.b or a[b] were not counted as a read of a.

@sharwell sharwell requested a review from a team as a code owner February 11, 2025 19:59
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 11, 2025
@sharwell sharwell merged commit b0d8330 into dotnet:main Feb 12, 2025
25 checks passed
@sharwell sharwell deleted the update-tests branch February 12, 2025 18:12
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Feb 12, 2025
This was referenced Feb 14, 2025
Closed
Closed
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Feb 17, 2025
Closed
@BrennanConroy BrennanConroy mentioned this pull request Feb 18, 2025
Closed
@dotnet-bot dotnet-bot mentioned this pull request Feb 20, 2025
Closed
@akhera99 akhera99 modified the milestones: Next, 17.14 P2 Feb 25, 2025
@dotnet-bot dotnet-bot mentioned this pull request Feb 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

+1 more reviewer

@arunchndr arunchndr arunchndr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode

Projects

None yet

Milestone

17.14 P2

Development

Successfully merging this pull request may close these issues.

4 participants

@sharwell @CyrusNajmabadi @arunchndr @akhera99