-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Publish symbols manually to internal feeds for PR validation #77088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c35f3b8 to
126a89f
Compare
f2fdbbf to
cf0354c
Compare
jaredpar
approved these changes
Apr 17, 2025
09c705f to
d34be12
Compare
JoeRobich
reviewed
Apr 22, 2025
1c351af to
282a160
Compare
f34fe96 to
85e027a
Compare
0342a26 to
2615ca0
Compare
3 tasks
a493939 to
f1853fb
Compare
JoeRobich
approved these changes
May 8, 2025
Member
Author
|
passing symbol check - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/635258 |
f1853fb to
1f3a0d0
Compare
JoeRobich
approved these changes
May 8, 2025
This was referenced May 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/635258
This switches our PR val builds to publish symbols to dnceng internal feeds only. They do not need to be public.
Previously, symbols were published by the automatic dnceng publishing step, but that published symbols using the channel configured for main, which is public. Instead, we now publish manually using darc to add to an internal only channel.
Previously we had considered manually using microbuild for this, but due to the way arcade creates symbol packages, it turned out to be more effort than manually invoking darc to publish to a specific channel.