Do not offer to convert typeof to nameof on a generic type #76920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
changed the title
akhera99
approved these changes
Jan 24, 2025
CyrusNajmabadi
commented
Jan 24, 2025
| // it's fine if an outer part of the name is generic (like `typeof(List<int>.Enumerator)`). as that will be | ||
| // convertible to `nameof(List<>.Enumerator)`. So we only need to check the type arguments directly on the type | ||
| // here, not on any containing types. | ||
| return namedType.TypeArguments.Length == 0; |
Member
Author
There was a problem hiding this comment.
note: we have tests for the non-generic nested in a generic.
This was referenced Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue reported by partner.
Note: nested types are fine and still can be converted (and we have tests for this).