Skip to content

Revert "Change PR Val builds to be unsigned (#76358)" #76866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dibarbet merged 1 commit into from
Jan 23, 2025
Merged

Revert "Change PR Val builds to be unsigned (#76358)" #76866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions azure-pipelines-pr-validation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ variables:
value: false
- name: Codeql.SkipTaskAutoInjection
value: true
- name: SignType
value: ''

# To retrieve OptProf data we need to authenticate to the VS drop storage.
# If the pipeline is running in DevDiv, the account has access to the VS drop storage.
Expand Down
15 changes: 0 additions & 15 deletions eng/Signing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,19 +61,4 @@
<FileSignInfo Include="Microsoft.VisualStudio.Threading.dll" CertificateName="MicrosoftSHA2" />
<FileSignInfo Include="StreamJsonRpc.dll" CertificateName="MicrosoftSHA2" />
</ItemGroup>

<!--
We do not intend to ship the artifacts produced for PR validation build so we can skip signing the artifacts.
-->
<Choose>
<When Condition="'$(PreReleaseVersionLabel)' == 'pr-validation' And '$(SignType)' == ''">
<ItemGroup>
<ItemsToSign Remove="@(ItemsToSign)" />
</ItemGroup>

<PropertyGroup>
<AllowEmptySignList>true</AllowEmptySignList>
</PropertyGroup>
</When>
</Choose>
</Project>
Loading