Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gen-method generating into top level. #76821

Merged
merged 10 commits into from
Jan 21, 2025
Merged

Fix gen-method generating into top level. #76821

merged 10 commits into from
Jan 21, 2025

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Jan 20, 2025 •
edited
Loading

Fixes #60136

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jan 20, 2025
@CyrusNajmabadi CyrusNajmabadi changed the title WIP: Fix gen-method generating into top level. Fix gen-method generating into top level. Jan 20, 2025
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review January 20, 2025 20:17
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner January 20, 2025 20:17
@CyrusNajmabadi
Copy link
Member Author

@dotnet/roslyn-ide ptal.

@CyrusNajmabadi
Copy link
Member Author

@JoeRobich ptal.

@CyrusNajmabadi
Copy link
Member Author

@ToddGrun ptal.

JoeRobich
JoeRobich approved these changes Jan 21, 2025
View reviewed changes
...AndExtensions/Workspace/Core/CodeGeneration/AbstractCodeGenerationService_FindDeclaration.cs

// Generate into any declaration we can find.
return (fallbackDeclaration, availableIndices: null);
bool TryAddToRelatedDeclaration(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool TryAddToRelatedDeclaration(
bool TryAddToRelatedDeclaration(

@CyrusNajmabadi CyrusNajmabadi merged commit 6c6b66f into dotnet:main Jan 21, 2025
25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the genIntoTopLevel branch January 21, 2025 05:27
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jan 21, 2025
This was referenced Jan 22, 2025
Closed
Closed
Closed
@dibarbet dibarbet modified the milestones: Next, 17.14 P1 Jan 28, 2025
@dotnet-bot dotnet-bot mentioned this pull request Jan 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeRobich JoeRobich JoeRobich approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Milestone
17.14 P1
Development

Successfully merging this pull request may close these issues.

Generate method should generate inside existing partial Program for top-level code
3 participants
@CyrusNajmabadi @JoeRobich @dibarbet