Change partial keyword recommender to better handle partial member syntax #76744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntax The partial keyword recommender for members was previously only allowing async/static keywords to precede it and relying on the type modifier code to catch other supported keywords. A better approach would be to have the member modifier check to not special case async/static, and instead check against all member modifiers (eg: virtual/override) Fixes dotnet#61439
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
Jan 14, 2025
This was referenced Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partial keyword recommender for members was previously only allowing async/static keywords to precede it and relying on the type modifier code to catch other supported keywords. A better approach would be to have the member modifier check not special case async/static, but instead check against all member modifiers (eg: virtual/override)
Fixes #61439