Skip to content

Remove Edgio CDN usage to release/dev17.8 #76604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dibarbet merged 10 commits into from
Jan 7, 2025
+12 −5
Merged

Remove Edgio CDN usage to release/dev17.8 #76604

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2fdd9f0
fix Edgio link
Jan 2, 2025
0181d98
updated telemetry version
Jan 3, 2025
cdc9d2c
update Utilities.Internal version
Jan 3, 2025
4f1f861
updated MSBuildStructuredLoggerVersion
Jan 4, 2025
76fa312
upgrade SystemCollectionsImmutableVersion
Jan 4, 2025
8adfe93
downgraded MSBuildStructuredLogger Version and SystemCollectionsImmut…
Jan 4, 2025
23780f6
upgrade the MSBuildStructuredLoggerVersion to the highest version tha…
Jan 6, 2025
0066d68
lowering the MSBuildStructuredLoggerVersion
Jan 6, 2025
9cf28bc
Use separate SCI version for build boss
dibarbet Jan 6, 2025
7e38523
use version name that buildboss is happy with
dibarbet Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@
<MicrosoftVisualStudioShell150Version>$(MicrosoftVisualStudioShellPackagesVersion)</MicrosoftVisualStudioShell150Version>
<MicrosoftVisualStudioShellFrameworkVersion>$(MicrosoftVisualStudioShellPackagesVersion)</MicrosoftVisualStudioShellFrameworkVersion>
<MicrosoftVisualStudioShellDesignVersion>$(MicrosoftVisualStudioShellPackagesVersion)</MicrosoftVisualStudioShellDesignVersion>
<MicrosoftVisualStudioTelemetryVersion>17.8.138</MicrosoftVisualStudioTelemetryVersion>
<MicrosoftVisualStudioTelemetryVersion>17.8.152</MicrosoftVisualStudioTelemetryVersion>
<MicrosoftVisualStudioTemplateWizardInterfaceVersion>8.0.0.0-alpha</MicrosoftVisualStudioTemplateWizardInterfaceVersion>
<MicrosoftVisualStudioTextDataVersion>$(VisualStudioEditorPackagesVersion)</MicrosoftVisualStudioTextDataVersion>
<MicrosoftVisualStudioTextInternalVersion>$(VisualStudioEditorPackagesVersion)</MicrosoftVisualStudioTextInternalVersion>
Expand All @@ -206,7 +206,7 @@
<MicrosoftVisualStudioThreadingAnalyzersVersion>$(MicrosoftVisualStudioThreadingPackagesVersion)</MicrosoftVisualStudioThreadingAnalyzersVersion>
<MicrosoftVisualStudioThreadingVersion>$(MicrosoftVisualStudioThreadingPackagesVersion)</MicrosoftVisualStudioThreadingVersion>
<MicrosoftVisualStudioUtilitiesVersion>$(MicrosoftVisualStudioShellPackagesVersion)</MicrosoftVisualStudioUtilitiesVersion>
<MicrosoftVisualStudioUtilitiesInternalVersion>16.3.53</MicrosoftVisualStudioUtilitiesInternalVersion>
<MicrosoftVisualStudioUtilitiesInternalVersion>16.3.56</MicrosoftVisualStudioUtilitiesInternalVersion>
<MicrosoftVisualStudioValidationVersion>17.6.11</MicrosoftVisualStudioValidationVersion>
<MicrosoftVisualStudioInteractiveWindowVersion>4.0.0</MicrosoftVisualStudioInteractiveWindowVersion>
<MicrosoftVisualStudioVsInteractiveWindowVersion>4.0.0</MicrosoftVisualStudioVsInteractiveWindowVersion>
Expand All @@ -215,7 +215,7 @@
<MicrosoftWin32PrimitivesVersion>4.3.0</MicrosoftWin32PrimitivesVersion>
<MicrosoftWin32RegistryVersion>5.0.0</MicrosoftWin32RegistryVersion>
<MicrosoftBuildLocatorVersion>1.6.10</MicrosoftBuildLocatorVersion>
<MSBuildStructuredLoggerVersion>2.2.206</MSBuildStructuredLoggerVersion>
<MSBuildStructuredLoggerVersion>2.2.386</MSBuildStructuredLoggerVersion>
<MDbgVersion>0.1.0</MDbgVersion>
<MonoOptionsVersion>6.6.0.161</MonoOptionsVersion>
<MoqVersion>4.10.1</MoqVersion>
Expand Down Expand Up @@ -316,7 +316,7 @@
When updating the S.C.I or S.R.M version please let the MSBuild team know in advance so they
can update to the same version. Version changes require a VS test insertion for validation.
-->
<SystemCollectionsImmutableVersion>7.0.0</SystemCollectionsImmutableVersion>
<SystemCollectionsImmutableVersion>8.0.0</SystemCollectionsImmutableVersion>

@dibarbet dibarbet Jan 4, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% certain we can do this - what triggered the upgrade here? If VS 17.8 itself isn't on 8.0 I believe we'll have issues

@jordi1215 jordi1215 Jan 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSBuildStructuredLoggerVersion version 2.2.386 depends on this according to the CI error message. Maybe we can try with a lower MSBuildStructuredLoggerVersion?

@dibarbet dibarbet Jan 6, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jordi1215 yeah lets try a lower version. Try 2.2.350, if that doesn't work I can help get other versions added so restore works

<SystemReflectionMetadataVersion>7.0.0</SystemReflectionMetadataVersion>
<MicrosoftBclAsyncInterfacesVersion>7.0.0</MicrosoftBclAsyncInterfacesVersion>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/VisualStudio/Core/Def/Storage/FileDownloader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public IFileDownloader CreateClient(string hostId, string serverPath, int pollin
{
// BaseUrl provided by the VS RemoteControl client team. This is URL we are supposed
// to use to publish and access data from.
const string BaseUrl = "https://az700632.vo.msecnd.net/pub";
const string BaseUrl = "https://aka.ms/vssettings/pub";

return new FileDownloader(new RemoteControlClient(hostId, BaseUrl, serverPath, pollingMinutes));
}
Expand Down