Make codepaths sync that don't need to be async #76490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
Contributor
Author
|
@jasonmalinowski @JoeRobich ptal. |
CyrusNajmabadi
commented
Dec 18, 2024
| if (_service.IsConstructorInitializerGeneration(_document, node, cancellationToken)) | ||
| { | ||
| if (!await TryInitializeConstructorInitializerGenerationAsync(node, cancellationToken).ConfigureAwait(false)) | ||
| if (!TryInitializeConstructorInitializerGeneration(node, cancellationToken)) |
Contributor
Author
There was a problem hiding this comment.
The core api these were all calling into is SymbolFinder.FindSourceDefinitionAsync. This method is just a wrapper around the synchronous SymbolFinder.FindSourceDefinition method (but part of the public api, so we can't remove it). Updating all internal callers to call the synchronous version caused a lot of code to become synchronous.
CyrusNajmabadi
commented
Dec 18, 2024
| => Task.FromResult(SymbolFinderInternal.FindSourceDefinition(symbol, solution, cancellationToken)); | ||
|
|
||
| /// <inheritdoc cref="FindSourceDefinitionAsync"/> | ||
| internal static ISymbol? FindSourceDefinition( |
Contributor
Author
There was a problem hiding this comment.
moved to shared location so it can be accessed by code-style layer as well.
CyrusNajmabadi
commented
Dec 18, 2024
|
|
||
| if (tokenNeedsConflictCheck) | ||
| { | ||
| newToken = RenameAndAnnotateAsync(token, newToken, isRenameLocation, isOldText).WaitAndGetResult_CanCallOnBackground(_cancellationToken); |
Contributor
Author
There was a problem hiding this comment.
removing this WaitAndGetResult_CanCallOnBackground was the original goal here.
CyrusNajmabadi
commented
Dec 18, 2024
| _solution, | ||
| symbols, | ||
| _cancellationToken) | ||
| .WaitAndGetResult_CanCallOnBackground(_cancellationToken); |
Contributor
Author
There was a problem hiding this comment.
this oen as well.
CyrusNajmabadi
commented
Dec 18, 2024
src/Workspaces/Core/Portable/Rename/ConflictEngine/ConflictResolver.Session.cs
Show resolved
Hide resolved
JoeRobich
approved these changes
Dec 18, 2024
3 tasks
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.