Remove an enumerator allocation in SymbolCompletionItem.CreateWorker #76375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small allocation, only showing up as about 0.1% of allocationsi n the typing scenario in the csharp editing speedometer test. However, the change is fairly simple, and I prefer the change as it passes around ImmutableArrays instead of IReadOnlyLists.
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
ToddGrun
commented
Dec 11, 2024
| @@ -82,28 +82,6 @@ public static bool IsStartingNewWord(SourceText text, int characterPosition, Fun | |||
| return true; | |||
| } | |||
|
|
|||
| public static Func<CancellationToken, Task<CompletionDescription>> CreateDescriptionFactory( | |||
ToddGrun
commented
Dec 11, 2024
|
|
||
| builder.Add(KeyValuePairUtil.Create("ContextPosition", contextPosition.ToString())); | ||
| AddSupportedPlatforms(builder, supportedPlatforms); | ||
| symbolEncoder(symbols, builder); | ||
|
|
||
| tags = tags.NullToEmpty(); | ||
| if (symbols.All(symbol => symbol.IsObsolete()) && !tags.Contains(WellKnownTags.Deprecated)) | ||
| if (!tags.Contains(WellKnownTags.Deprecated) && symbols.All(static symbol => symbol.IsObsolete())) |
ToddGrun
commented
Dec 11, 2024
| @@ -42,7 +43,7 @@ public static CompletionItem CreateSymbolCompletionItem( | |||
| SupportedPlatformData? supportedPlatforms = null, | |||
| ImmutableDictionary<string, string>? properties = null, | |||
| ImmutableArray<string> tags = default) | |||
| => SymbolCompletionItem.CreateWithSymbolId(displayText, displayTextSuffix: null, symbols, rules, contextPosition, sortText, insertionText, | |||
| => SymbolCompletionItem.CreateWithSymbolId(displayText, displayTextSuffix: null, symbols.ToImmutableArray(), rules, contextPosition, sortText, insertionText, | |||
CyrusNajmabadi
approved these changes
Dec 11, 2024
3 tasks
This was referenced Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small allocation, only showing up as about 0.1% of allocationsi n the typing scenario in the csharp editing speedometer test. However, the change is fairly simple, and I prefer the change as it passes around ImmutableArrays instead of IReadOnlyLists.
*** relevant allocations from the csharp editing speedometer test ***
