Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable LSP go to definition on string literals #76291

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Dec 6, 2024

Resolves #56765

gtd_string

@dibarbet dibarbet requested a review from a team as a code owner December 6, 2024 00:09
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Dec 6, 2024
@JoeRobich
Copy link
Member

JoeRobich commented Dec 6, 2024

I feel like this change should be made to Go to Type Definition instead. Literals are defined at their location and this is instead going to the literal's type.

@dibarbet
Copy link
Member Author

dibarbet commented Dec 6, 2024

I feel like this change should be made to Go to Type Definition instead. Literals are defined at their location and this is instead going to the literal's type.

go to type definition does work for that already (no change needed). Happy to say someone should use go to type definition instead, but I also don't mind if go to definition also supported this (also makes it work in VS Razor which doesn't have go to type def)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LSP] Goto/Peek definition on string literal does not go to definition
3 participants