Fix LangVersion computation on non-English locales #76070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Compilers
untriaged
Youssef1313
reviewed
Nov 25, 2024
Member
Youssef1313
left a comment
Youssef1313
left a comment
There was a problem hiding this comment.
Isn't this related to the bug on MSBuild side?
Member
Author
Yes, that looks related. Thanks for the link. |
jaredpar
reviewed
Nov 25, 2024
| --> | ||
| <_MaxSupportedLangVersion Condition="'$(TargetFrameworkIdentifier)' == '.NETCoreApp' AND | ||
| '$(_MaxSupportedLangVersion)' == ''">$([MSBuild]::Add(9, $([MSBuild]::Subtract($(_TargetFrameworkVersionWithoutV), 5)))).0</_MaxSupportedLangVersion> | ||
| '$(_MaxSupportedLangVersion)' == ''">$([MSBuild]::Add(9, $([MSBuild]::Subtract($(_TargetFrameworkVersionWithoutV.Split('.')[0]), 5)))).0</_MaxSupportedLangVersion> |
Member
There was a problem hiding this comment.
Can we add a comment that points to the msbuild issue about localization?
jaredpar
approved these changes
Nov 25, 2024
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing Spanish leg in roslyn-CI after #75795.
Given
$(_TargetFrameworkVersionWithoutV)=5.0, the subtraction$([MSBuild]::Subtract($(_TargetFrameworkVersionWithoutV), 5))evaluates to45(I guess because the period in5.0is not interpreted as decimal separator but as thousands separator instead). Adding.Split('.')[0]makes sure only the major version is taken and the subtraction works.