-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Update breaking change docs #75789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update breaking change docs #75789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offline, we had a discussion that the title and H1 were verbose and could be misunderstood. I've updated the most recent 4 documents to match that discussion. Notes for reviewers: All edits in each file should be the same (modulo typos and version numbers). Let's agree on the language on one of them, then make sure they all match.
Member
Author
jcouv
reviewed
Nov 6, 2024
jcouv
reviewed
Nov 6, 2024
BillWagner
added a commit
to BillWagner/docs
that referenced
this pull request
Nov 6, 2024
The TOC node and the descriptions could be misleading here. Fixes dotnet#43291 Related to dotnet/roslyn#75789
333fred
reviewed
Nov 6, 2024
333fred
reviewed
Nov 6, 2024
jcouv
approved these changes
Nov 6, 2024
Member
jcouv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks (iteration 4)
333fred
approved these changes
Nov 6, 2024
BillWagner
added a commit
to BillWagner/razor
that referenced
this pull request
Nov 7, 2024
Mirror the changes in dotnet/roslyn#75789
BillWagner
added a commit
to dotnet/docs
that referenced
this pull request
Nov 7, 2024
The TOC node and the descriptions could be misleading here. Fixes #43291 Related to dotnet/roslyn#75789
DustinCampbell
added a commit
to dotnet/razor
that referenced
this pull request
Nov 7, 2024
Mirror the changes in dotnet/roslyn#75789 See dotnet/AspNetCore.Docs#33996
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area-Compilers
Community
The pull request was submitted by a contributor who is not a Microsoft employee.
Documentation
untriaged
Issues and PRs which have not yet been triaged by a lead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offline, we had a discussion that the title and H1 were verbose and could be misunderstood.
I've updated the most recent 4 documents to match that discussion.
Notes for reviewers:
All edits in each file should be the same (modulo typos and version numbers). Let's agree on the language on one of them, then make sure they all match.