Skip to content

Conversation

@BillWagner
Copy link
Member

Offline, we had a discussion that the title and H1 were verbose and could be misunderstood.

I've updated the most recent 4 documents to match that discussion.

Notes for reviewers:

All edits in each file should be the same (modulo typos and version numbers). Let's agree on the language on one of them, then make sure they all match.

Offline, we had a discussion that the title and H1 were verbose and could be misunderstood.

I've updated the most recent 4 documents to match that discussion.

Notes for reviewers:

All edits in each file should be the same (modulo typos and version numbers). Let's agree on the language on one of them, then make sure they all match.
@BillWagner BillWagner requested a review from a team as a code owner November 6, 2024 19:36
@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Nov 6, 2024
@BillWagner
Copy link
Member Author

PTAL @jcouv @333fred

@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Nov 6, 2024
@jcouv jcouv self-assigned this Nov 6, 2024
BillWagner added a commit to BillWagner/docs that referenced this pull request Nov 6, 2024
The TOC node and the descriptions could be misleading here.

Fixes dotnet#43291

Related to dotnet/roslyn#75789
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 4)

@333fred 333fred merged commit 103fe0c into dotnet:main Nov 6, 2024
5 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 6, 2024
@BillWagner BillWagner deleted the breaking-change-title branch November 7, 2024 14:16
BillWagner added a commit to BillWagner/razor that referenced this pull request Nov 7, 2024
BillWagner added a commit to dotnet/docs that referenced this pull request Nov 7, 2024
The TOC node and the descriptions could be misleading here.

Fixes #43291

Related to dotnet/roslyn#75789
DustinCampbell added a commit to dotnet/razor that referenced this pull request Nov 7, 2024
@jjonescz jjonescz removed this from the Next milestone Nov 25, 2024
@jjonescz jjonescz added this to the 17.13 P2 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Documentation untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants