Skip to content

Conversation

@jcouv
Copy link
Member

@jcouv jcouv commented Oct 23, 2024

Fixes #75603

Validated that the correctness legs fail in CI prior to fixing the xml comment in IOperationInterfaces.xml:

========================== Starting Command Output ===========================
...
Running CompilersIOperationGenerator.csproj "D:\a\_work\1\s\src\Compilers\Core\Portable\Operations\OperationInterfaces.xml" "D:\a\_work\1\s\artifacts\log\Release\Generated\Core\Operations"
D:\a\_work\1\s\.dotnet\dotnet.exe run --project D:\a\_work\1\s\src\Tools\Source\CompilerGeneratorTools\Source\IOperationGenerator\CompilersIOperationGenerator.csproj --framework net9.0 "D:\a\_work\1\s\src\Compilers\Core\Portable\Operations\OperationInterfaces.xml" "D:\a\_work\1\s\artifacts\log\Release\Generated\Core\Operations"
�]9;4;3;�\�]9;4;0;�\IConditionalOperation.IsRef does not have correctly formatted comments, please ensure that there is a <summary> block for the property.
Encountered xml errors, not generating
Command failed to execute with exit code 1: D:\a\_work\1\s\.dotnet\dotnet.exe run --project D:\a\_work\1\s\src\Tools\Source\CompilerGeneratorTools\Source\IOperationGenerator\CompilersIOperationGenerator.csproj --framework net9.0 "D:\a\_work\1\s\src\Compilers\Core\Portable\Operations\OperationInterfaces.xml" "D:\a\_work\1\s\artifacts\log\Release\Generated\Core\Operations"
##[error]PowerShell exited with code '1'.
Finishing: Generate Syntax Files

@jcouv jcouv self-assigned this Oct 23, 2024
@ghost ghost added the untriaged Issues and PRs which have not yet been triaged by a lead label Oct 23, 2024
@jcouv jcouv marked this pull request as ready for review October 23, 2024 20:41
@jcouv jcouv requested a review from a team as a code owner October 23, 2024 20:41

IOperationClassWriter.Write(tree, outFilePath);

return 0;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch ...

@jcouv jcouv enabled auto-merge (squash) October 23, 2024 21:34
@jcouv jcouv merged commit 8dd25e5 into dotnet:main Oct 23, 2024
28 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 23, 2024
@akhera99 akhera99 modified the milestones: Next, 17.13 P1 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CompilersIOperationGenerator error should cause the correctness leg to fail

4 participants