Move 'generate XXX' code fixers down to code-style layer. #74567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
changed the title
This was referenced Jul 26, 2024
Open
Member
Author
|
@dibarbet ptal. |
Member
Author
|
@davidbritch @ToddGrun ptal. |
CyrusNajmabadi
commented
Jul 27, 2024
| @@ -2788,74 +2784,6 @@ class D | |||
| """); | |||
| } | |||
|
|
|||
| [Fact, WorkItem("http://vstfdevdiv:8080/DevDiv2/DevDiv/_workitems/edit/530003")] | |||
Member
Author
There was a problem hiding this comment.
these teests moved to the end. they're enabled for non-CODESTYLE layer as they depend on humanizer (which codestyle doesn't ship with).
CyrusNajmabadi
commented
Jul 27, 2024
| <data name="TODO_colon_override_finalizer_only_if_0_has_code_to_free_unmanaged_resources" xml:space="preserve"> | ||
| <value>TODO: override finalizer only if '{0}' has code to free unmanaged resources</value> | ||
| </data> | ||
| <data name="Generate_constant_0" xml:space="preserve"> |
Member
Author
There was a problem hiding this comment.
lots of resource moves. it's hte majority of hte diff.
CyrusNajmabadi
commented
Jul 27, 2024
src/Analyzers/Core/CodeFixes/GenerateConstructor/AbstractGenerateConstructorService.State.cs
Outdated
Show resolved
Hide resolved
dibarbet
approved these changes
Jul 29, 2024
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.