Skip to content

Fix race condition in LSP FindAllReferences when linked files were involved. #74566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 26, 2024
Merged

Fix race condition in LSP FindAllReferences when linked files were involved. #74566

merged 5 commits into from
Jul 26, 2024

Conversation

@dibarbet
Copy link
Member

@dibarbet dibarbet commented Jul 26, 2024 •
edited by 333fred
Loading

Fixes dotnet/vscode-csharp#7391

TestFindAllReferencesAsync_LinkedFile should fail a few times (other passes)

@ghost ghost added Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 26, 2024
333fred
333fred reviewed Jul 26, 2024
View reviewed changes
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review July 26, 2024 18:02
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner July 26, 2024 18:02
@CyrusNajmabadi CyrusNajmabadi changed the title Add FAR tests to demonstrate failure Fix race condition in FindAllReferences. Jul 26, 2024
@CyrusNajmabadi CyrusNajmabadi enabled auto-merge July 26, 2024 18:03
@CyrusNajmabadi CyrusNajmabadi changed the title Fix race condition in FindAllReferences. Fix race condition in LSP FindAllReferences when linked files were involved. Jul 26, 2024
@CyrusNajmabadi
Copy link
Member

CyrusNajmabadi commented Jul 26, 2024

Introduced in #73613.

ToddGrun
ToddGrun approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi merged commit e8c1ac0 into dotnet:main Jul 26, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jul 26, 2024
@RikkiGibson RikkiGibson modified the milestones: Next, 17.12 P1 Jul 29, 2024
This was referenced Jul 31, 2024
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi left review comments

@333fred 333fred 333fred approved these changes

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees

No one assigned

Labels

Area-Infrastructure untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.12 P1

Development

Successfully merging this pull request may close these issues.

Find-All-References results incomplete and unstable

5 participants

@dibarbet @CyrusNajmabadi @333fred @ToddGrun @RikkiGibson