Remove C++ sources from repo #74481
Merged
Remove C++ sources from repo #74481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C++ sources are triggering CodeQL checks. Suppressing them / getting exceptions is very tricky. Instead just removing this code. The majority of it was written to validate our floating point parsing code compared to the C++ impl. It's been ages since that was needed. Can recover it by looking at this commit in the future if needed.
ghost
added
Area-Compilers
untriaged
arunchndr
approved these changes
Jul 22, 2024
Member
Author
|
@dotnet/roslyn-compiler PTAL |
chsienki
approved these changes
Jul 22, 2024
sharwell
approved these changes
Jul 22, 2024
jcouv
approved these changes
Jul 22, 2024
jcouv
approved these changes
Jul 22, 2024
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The C++ sources are triggering CodeQL checks. Suppressing them / getting exceptions is very tricky. Instead just removing this code. The majority of it was written to validate our floating point parsing code compared to the C++ impl. It's been ages since that was needed. Can recover it by looking at this commit in the future if needed.