Use correct get / set inside ref safety analysis #73842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-Compilers
untriaged
This code path for checking the receiver is unnecessary. The receiver is included in `escapeArguments` below where the same check happens. Added a test that hit the old code path and failed and verified it still fails after this change. closes dotnet#73550
jaredpar
commented
Jun 13, 2024
| case BoundKind.PropertyGroup: | ||
| expr = BindIndexedPropertyAccess((BoundPropertyGroup)expr, mustHaveAllOptionalParameters: false, diagnostics: diagnostics); | ||
| if (expr is BoundIndexerAccess indexerAccess) | ||
| { |
Member
Author
There was a problem hiding this comment.
Put this inside { ... } blocks as it's now declaring variables.
jaredpar
commented
Jun 13, 2024
| Error(diagnostics, errorCode, syntax, symbol, parameterName); | ||
| } | ||
|
|
||
| private bool UseUpdatedEscapeRulesForInvocation(Symbol symbol) |
Member
Author
There was a problem hiding this comment.
Moved to MethodInfo.UseUpdatedEscapeRules
jaredpar
commented
Jun 13, 2024
| // https://github.com/dotnet/roslyn/issues/73550: | ||
| // We do not have a test that demonstrates that the statement below makes a difference. | ||
| // If it is commented out, not a single test fails | ||
| escapeTo = GetValEscape(receiverOpt, scopeOfTheContainingExpression); |
Member
Author
There was a problem hiding this comment.
This code is indeed unnecessary. Thinking through the check for IsReceiverRefReadOnly is what caused me to dig into the get / set issues with indexers though.
jaredpar
commented
Jun 13, 2024
| return escapeScope; | ||
| } | ||
|
|
||
| private static bool ReturnsRefToRefStruct(Symbol symbol) |
Member
Author
There was a problem hiding this comment.
Moved to MethodInfo.ReturnsRefToRefStruct
Member
Author
|
@dotnet/roslyn-compiler PTAL |
1 similar comment
Member
Author
|
@dotnet/roslyn-compiler PTAL |
cston
reviewed
Jun 15, 2024
cston
reviewed
Jun 15, 2024
cston
reviewed
Jun 15, 2024
cston
reviewed
Jun 15, 2024
cston
reviewed
Jun 15, 2024
cston
reviewed
Jun 15, 2024
cston
reviewed
Jun 15, 2024
cston
reviewed
Jun 15, 2024
cston
reviewed
Jun 15, 2024
cston
reviewed
Jun 15, 2024
cston
reviewed
Jun 15, 2024
cston
previously approved these changes
Jun 15, 2024
Contributor
cston
left a comment
cston
left a comment
There was a problem hiding this comment.
A few suggestions, but nothing blocking.
jjonescz
reviewed
Jun 17, 2024
cston
reviewed
Jul 10, 2024
cston
reviewed
Jul 10, 2024
cston
reviewed
Jul 10, 2024
cston
reviewed
Jul 10, 2024
Co-authored-by: Rikki Gibson <[email protected]>
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
cston
reviewed
Jul 11, 2024
cston
reviewed
Jul 11, 2024
src/Compilers/CSharp/Test/Semantic/Semantics/RefEscapingTests.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Jul 11, 2024
cston
reviewed
Jul 11, 2024
cston
reviewed
Jul 11, 2024
cston
reviewed
Jul 11, 2024
Open
3 tasks
cston
approved these changes
Jul 12, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few cases where our code looked at the wrong accessor when doing ref safety analysis.
closes #35606
closes #73550
related #73872
related dotnet/csharplang#8253