Suppress the struct==null warning except in "strict" mode - #738
Merged
Conversation
Member
Author
|
@jaredpar @VSadov @AlekseyTs @agocke @VladimirReshetnikov Could a couple of you review this please? |
gafter
added
Area-Compilers
4 - In Review
Member
|
LGTM |
Contributor
There was a problem hiding this comment.
Is this additive? I would expect WithStrictMode helper to preserve whatever features already set.
Member
Author
There was a problem hiding this comment.
As it turns out, a test helper that preserves other feature flags wasn't needed, as there are no other features that we test at the same time.
Contributor
There was a problem hiding this comment.
Then the name of the method is confusing and should be changed to make it clear that it overwrites Features.
Member
Author
|
@AlekseyTs I believe your review comments have been addressed. |
Member
|
LGTM |
1 similar comment
Contributor
|
LGTM |
gafter
added a commit
that referenced
this pull request
Feb 23, 2015
Suppress the struct==null warning except in "strict" mode
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
* Component Debugger - See dotnet/roslyn-sdk#726 * Add command line data source: - add data source to obtain command line args - use data source in extension method - extract out shared logic into launchsettingsmanager - clean up VM code * Remove capability provider - Use targets directly instead
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #663