Skip to content

Expose folding range functionality to Razor #73609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 21, 2024
Merged

Expose folding range functionality to Razor #73609

merged 4 commits into from
May 21, 2024

Conversation

@davidwengier
Copy link
Member

@davidwengier davidwengier commented May 21, 2024

Three things:

  • Allow Razor to get folding ranges through a C# call rather than LSP
  • Expose LSP types through restricted IVT so we don't have to wrap the return from the above call
  • Minor fix to Json formatter code just in case

@davidwengier davidwengier requested a review from dibarbet May 21, 2024 05:47
@davidwengier davidwengier requested a review from a team as a code owner May 21, 2024 05:47
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 21, 2024
dibarbet
dibarbet approved these changes May 21, 2024
View reviewed changes
src/Features/LanguageServer/Protocol/Microsoft.CodeAnalysis.LanguageServer.Protocol.csproj
<!-- Full IVT is through ExternalAccess for functionality -->
<InternalsVisibleTo Include="Microsoft.CodeAnalysis.ExternalAccess.Razor" />
<!-- Restricted IVT is direct for protocol types only -->
<RestrictedInternalsVisibleTo Include="Microsoft.CodeAnalysis.Remote.Razor" Namespace="Roslyn.LanguageServer.Protocol" Partner="Razor" Key="$(RazorKey)" />
Copy link
Member

@dibarbet dibarbet May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess my hand is being forced, I have to write the readme of how to make breaking changes here 😆

Copy link
Member Author

@davidwengier davidwengier May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reject this bit of the PR if you want, I can deal with that, but you could also just put off writing the readme until you make the first breaking change.. and then don't 😛

@davidwengier davidwengier enabled auto-merge May 21, 2024 22:07
@davidwengier davidwengier merged commit 1d8582e into dotnet:main May 21, 2024
@davidwengier davidwengier deleted the RazorFoldingRanges branch May 21, 2024 23:25
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone May 21, 2024
@davidwengier davidwengier mentioned this pull request May 27, 2024
Closed
@Cosifne Cosifne modified the milestones: Next, 17.11 P2 May 28, 2024
@davidwengier davidwengier mentioned this pull request May 30, 2024
Open
This was referenced Jun 4, 2024
Closed
Closed
Closed
@dotnet-bot dotnet-bot mentioned this pull request Jun 27, 2024
Closed
@dibarbet dibarbet mentioned this pull request Jul 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi left review comments

@dibarbet dibarbet dibarbet approved these changes

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.11 P2

Development

Successfully merging this pull request may close these issues.

4 participants

@davidwengier @CyrusNajmabadi @dibarbet @Cosifne