Show 'else' within Ifs within Elses - #734
Merged
Merged
Conversation
When recommending "Else" we walk all the way up the tree to determine if the position is nested inside an Else block. This means we don't recommend "Else" inside an If block nested within an Else block. When walking up the tree, we should stop at the If/ElseIf block.
Contributor
Author
|
Potential reviewers: @brettfo @balajikris @dpoeschl @basoundr @jasonmalinowski @DustinCampbell @Pilchie |
Contributor
There was a problem hiding this comment.
If the TargetToken is the ThenKeyword, then can bad things happen if you fall through to the code below? Doesn't look like the code below is set up to deal with the ThenKeyword.
rchande
added a commit
that referenced
this pull request
Feb 26, 2015
Show 'else' within Ifs within Elses Fixes #719
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
Add support for .editorconfig documents
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When recommending "Else" we walk all the way up the tree to determine
if the position is nested inside an Else block. This means we don't
recommend "Else" inside an If block nested within an Else block. When
walking up the tree, we should stop at the If/ElseIf block.
Fixes #719.