Skip to content

Fix potential exception in AssetProvider.SynchronizeAssetsAsync #72597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToddGrun merged 1 commit into from
Mar 19, 2024
+15 −0
Merged

Fix potential exception in AssetProvider.SynchronizeAssetsAsync #72597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Workspaces/Remote/ServiceHub/Host/AssetProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,21 @@ public async ValueTask SynchronizeAssetsAsync(
{
if (!_assetCache.TryGetAsset<object>(checksum, out _))
{
if (missingChecksumsCount == missingChecksums.Length)
{
// This can happen if the asset cache has been modified by another thread during this method's execution.
var newMissingChecksums = new Checksum[missingChecksumsCount * 2];
Array.Copy(missingChecksums, newMissingChecksums, missingChecksumsCount);

if (usePool)
{
s_checksumPool.Free(missingChecksums);
usePool = false;
}

missingChecksums = newMissingChecksums;
}

missingChecksums[missingChecksumsCount] = checksum;
missingChecksumsCount++;
}
Expand Down