Skip to content

Forward the call to global option service #72128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Cosifne merged 1 commit into from
Feb 15, 2024
Merged

Forward the call to global option service #72128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Features/LanguageServer/Protocol/Features/Options/CompletionOptionsStorage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

using Microsoft.CodeAnalysis.CodeStyle;
using Microsoft.CodeAnalysis.Options;
using Roslyn.Utilities;

namespace Microsoft.CodeAnalysis.Completion;

Expand All @@ -21,7 +20,8 @@ public static CompletionOptions GetCompletionOptions(this IGlobalOptionService o
// If the option is null (i.e. default) or 'true', then we want to trigger completion.
// Only if the option is false do we not want to trigger.
LanguageNames.VisualBasic => options.GetOption(TriggerOnDeletion, language) is not false,
_ => throw ExceptionUtilities.Unreachable()
// Other languages might want to get completion options, like Razor, just forward the call to option service when it happens.
_ => options.GetOption(TriggerOnDeletion, language),
Comment on lines +23 to +24
Copy link
Member

@jasonmalinowski jasonmalinowski Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be the same as the VB branch, and if so can we just delete the VB branch?

Copy link
Member Author

@Cosifne Cosifne Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

null means razor could decided the behavior by itselfs
For VB:
true -> true,
null -> true,
false -> false.

I don't know if razor wants the same behavior, but I intend to keep Vb seperate here

},
TriggerInArgumentLists = options.GetOption(TriggerInArgumentLists, language),
EnterKeyBehavior = options.GetOption(EnterKeyBehavior, language),
Expand Down