Skip to content

Defer parsing syntax trees when computing frozen partial solutions #72090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CyrusNajmabadi merged 16 commits into from
Feb 16, 2024
Merged

Defer parsing syntax trees when computing frozen partial solutions #72090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e27bb84
Merge branch 'main' into frozenPartialSyntaxTree
CyrusNajmabadi Feb 13, 2024
92e8fdb
Defer parsing syntax trees when computing frozen partial solutions
CyrusNajmabadi Feb 13, 2024
39dff43
simplify
CyrusNajmabadi Feb 13, 2024
85ba620
docs
CyrusNajmabadi Feb 13, 2024
0d03232
preserve
CyrusNajmabadi Feb 13, 2024
e3c6c2f
fix
CyrusNajmabadi Feb 13, 2024
ae90a86
Update test
CyrusNajmabadi Feb 13, 2024
4ec51f6
Simplify
CyrusNajmabadi Feb 13, 2024
ac5b220
Simplify
CyrusNajmabadi Feb 13, 2024
6c7fdb7
Update src/Workspaces/Core/Portable/Workspace/Solution/SolutionCompil…
CyrusNajmabadi Feb 13, 2024
cbd1e58
Merge branch 'main' into frozenPartialSyntaxTree
CyrusNajmabadi Feb 14, 2024
4e98024
Simplify
CyrusNajmabadi Feb 14, 2024
52a13be
Separate methods
CyrusNajmabadi Feb 14, 2024
6f7d2a4
Merge remote-tracking branch 'upstream/main' into frozenPartialSyntax…
CyrusNajmabadi Feb 14, 2024
9db05f5
indent
CyrusNajmabadi Feb 14, 2024
a16da4e
lint
CyrusNajmabadi Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions ...Workspace/Solution/SolutionCompilationState.CompilationTracker.CompilationTrackerState.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ private InProgressState(
Compilation compilationWithoutGeneratedDocuments,
CompilationTrackerGeneratorInfo generatorInfo,
Compilation? staleCompilationWithGeneratedDocuments,
ImmutableList<(ProjectState state, CompilationAndGeneratorDriverTranslationAction action)> pendingTranslationSteps)
ImmutableList<(ProjectState oldState, CompilationAndGeneratorDriverTranslationAction action)> pendingTranslationSteps)
Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming for consistency.

: base(isFrozen,
compilationWithoutGeneratedDocuments,
generatorInfo)
Expand All @@ -108,7 +108,7 @@ public static InProgressState Create(
Compilation compilationWithoutGeneratedDocuments,
CompilationTrackerGeneratorInfo generatorInfo,
Compilation? staleCompilationWithGeneratedDocuments,
ImmutableList<(ProjectState state, CompilationAndGeneratorDriverTranslationAction action)> pendingTranslationSteps)
ImmutableList<(ProjectState oldState, CompilationAndGeneratorDriverTranslationAction action)> pendingTranslationSteps)
{
Contract.ThrowIfTrue(pendingTranslationSteps is null);

Expand Down Expand Up @@ -166,7 +166,10 @@ private FinalCompilationTrackerState(
: base(isFrozen, compilationWithoutGeneratedDocuments, generatorInfo)
{
Contract.ThrowIfNull(finalCompilationWithGeneratedDocuments);
HasSuccessfullyLoaded = hasSuccessfullyLoaded;

// As a policy, all partial-state projects are said to have incomplete references, since the
// state has no guarantees.
Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved from a different location here, so that we're consistent on what this bit means wrt frozen states.

HasSuccessfullyLoaded = hasSuccessfullyLoaded && !isFrozen;
FinalCompilationWithGeneratedDocuments = finalCompilationWithGeneratedDocuments;
UnrootedSymbolSet = unrootedSymbolSet;

Expand Down Expand Up @@ -205,6 +208,14 @@ public static FinalCompilationTrackerState Create(
unrootedSymbolSet);
}

public FinalCompilationTrackerState WithIsFrozen()
=> new(isFrozen: true,
Copy link
Contributor

@ToddGrun ToddGrun Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new

no check to return this if already frozen?

Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair. i can do that.

Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put into: #72111

FinalCompilationWithGeneratedDocuments,
CompilationWithoutGeneratedDocuments,
HasSuccessfullyLoaded,
GeneratorInfo,
UnrootedSymbolSet);

private static void RecordAssemblySymbols(ProjectId projectId, Compilation compilation, Dictionary<MetadataReference, ProjectId>? metadataReferenceToProjectId)
{
RecordSourceOfAssemblySymbol(compilation.Assembly, projectId);
Expand Down
Loading