Use Microsoft.NetFX20 package in ResultProviders - #720
Conversation
There was a problem hiding this comment.
Sanity check: it will still run on 2.0?
There was a problem hiding this comment.
Yes, this is only the version of tools that are used. The properties set below make sure that msbuild doesn't try to apply implicitly generated stuff for 4.5.
There was a problem hiding this comment.
You might want to add a comment here that the TFV here is actually a lie.
|
The parts I understood LGTM. :) |
|
@jasonmalinowski to review the msbuild hackery :) |
There was a problem hiding this comment.
I would change the comment to something like:
// A few dependencies from System.dll...we will avoid referencing the full library to promote portability...
|
LGTM |
|
I'm not sure "looks good" is something I can really say given the abuse this is applying to the poor project system. So we'll go with 😬 instead. |
There was a problem hiding this comment.
More specific comment about VB auto importing this would be useful then.
Use Microsoft.NetFX20 package in ResultProviders
Use MSBuildProjectFile instead of MSBuildProjectFullPath
5 participants
Microsoft.NetFX20 package provides a reference assembly for mscorlib 2.0. Use it in ResultProviders instead of referencing mscorlib 2.0 installed on the machine.
Also remove a reference to System.dll.