Upgrade Language Server to run on .NET 8 #71903
Conversation
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
| @@ -42,7 +42,7 @@ | |||
| <PublishDir Condition="'$(RuntimeIdentifier)' == ''">$(ArtifactsDir)/LanguageServer/$(Configuration)/$(TargetFramework)/neutral</PublishDir> | |||
|
|
|||
| <!-- List of runtime identifiers that we want to publish an executable for --> | |||
| <RuntimeIdentifiers>win-x64;win-x86;win-arm64;linux-x64;linux-arm64;alpine-x64;alpine-arm64;osx-x64;osx-arm64</RuntimeIdentifiers> | |||
There was a problem hiding this comment.
alpine-xyz RIDs are deprecated in .net8, we should use the portable RID instead of the distro RID.
https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/rid-graph
|
Signed off from my side. Assuming we are just holding off on the CTI and partner coordination activities. |
Still need to finish testing myself with the client side changes, then I plan to merge this PR (it's targeting features/vscode_net8) so that we have packages to use on the vscode side feature branch. When CTI / partners are signed off, we'll merge the feature branches back into main. |
| @@ -15,7 +15,7 @@ | |||
| <NetRoslyn>net8.0</NetRoslyn> | |||
| <NetRoslynAll>net7.0;net8.0</NetRoslynAll> | |||
| <NetVS>net8.0</NetVS> | |||
| <NetVSCode>net7.0</NetVSCode> | |||
| <NetVSCode>net8.0</NetVSCode> | |||
There was a problem hiding this comment.
Not saying it has to be part of this PR, but this would mean you could delete that load-all-assemblies-upfront hack we have to work around the 7.0.4 runtime bug.
There was a problem hiding this comment.
I'll do that in a followup to avoid conflicts with my other pending PR there.
dibarbet
force-pushed
the
languageserver_net8
branch
from
565b097 to
5da4c7f
Compare
This is merging into a feature branch so we can run validation through CTI and partners before merging.
Client side PR - dotnet/vscode-csharp#6840