Onboard C# Intellisense page to Unified Settings

src/Features/LanguageServer/Protocol/Features/Options/CompletionOptionsStorage.cs

@@ -4,6 +4,7 @@
 
 using Microsoft.CodeAnalysis.CodeStyle;
 using Microsoft.CodeAnalysis.Options;
+using Roslyn.Utilities;
 
 namespace Microsoft.CodeAnalysis.Completion;
 
@@ -14,7 +15,14 @@ public static CompletionOptions GetCompletionOptions(this IGlobalOptionService o
         {
             TriggerOnTyping = options.GetOption(TriggerOnTyping, language),
             TriggerOnTypingLetters = options.GetOption(TriggerOnTypingLetters, language),
-            TriggerOnDeletion = options.GetOption(TriggerOnDeletion, language),
+            TriggerOnDeletion = language switch
+            {
+                LanguageNames.CSharp => options.GetOption(TriggerOnTypingLetters, language) && options.GetOption(TriggerOnDeletion, language) is true,
+                // If the option is null (i.e. default) or 'true', then we want to trigger completion.
+                // Only if the option is false do we not want to trigger.
+                LanguageNames.VisualBasic => options.GetOption(TriggerOnDeletion, language) is not false,
+                _ => throw ExceptionUtilities.Unreachable()
+            },
             TriggerInArgumentLists = options.GetOption(TriggerInArgumentLists, language),
             EnterKeyBehavior = options.GetOption(EnterKeyBehavior, language),
             SnippetsBehavior = options.GetOption(SnippetsBehavior, language),

src/VisualStudio/CSharp/Impl/CSharpPackage.cs

@@ -15,10 +15,8 @@
 using Microsoft.VisualStudio.LanguageServices.CSharp.ObjectBrowser;
 using Microsoft.VisualStudio.LanguageServices.CSharp.ProjectSystemShim;
 using Microsoft.VisualStudio.LanguageServices.CSharp.ProjectSystemShim.Interop;
-using Microsoft.VisualStudio.LanguageServices.Implementation;
 using Microsoft.VisualStudio.LanguageServices.Implementation.LanguageService;
 using Microsoft.VisualStudio.LanguageServices.Implementation.ProjectSystem;
-using Microsoft.VisualStudio.LanguageServices.Utilities;
 using Microsoft.VisualStudio.Shell;
 using Microsoft.VisualStudio.Shell.Interop;
 using Task = System.Threading.Tasks.Task;

src/VisualStudio/CSharp/Impl/Options/IntelliSenseOptionPageControl.xaml.cs

@@ -27,7 +27,6 @@ public IntelliSenseOptionPageControl(OptionStore optionStore) : base(optionStore
             BindToOption(Show_completion_item_filters, CompletionViewOptionsStorage.ShowCompletionItemFilters, LanguageNames.CSharp);
 
             BindToOption(Automatically_complete_statement_on_semicolon, CompleteStatementOptionsStorage.AutomaticallyCompleteStatementOnSemicolon);
-
             BindToOption(Never_include_snippets, CompletionOptionsStorage.SnippetsBehavior, SnippetsRule.NeverInclude, LanguageNames.CSharp);
             BindToOption(Always_include_snippets, CompletionOptionsStorage.SnippetsBehavior, SnippetsRule.AlwaysInclude, LanguageNames.CSharp);
             BindToOption(Include_snippets_when_question_Tab_is_typed_after_an_identifier, CompletionOptionsStorage.SnippetsBehavior, SnippetsRule.IncludeAfterTypingIdentifierQuestionTab, LanguageNames.CSharp);

src/VisualStudio/CSharp/Impl/VSPackage.resx

@@ -363,4 +363,25 @@ Show items from unimported namespaces (experimental);</value>
   <data name="An_empty_CSharp_script_file" xml:space="preserve">
     <value>An empty C# script file.</value>
   </data>
+  <data name="Always_add_new_line_on_enter" xml:space="preserve">
+    <value>Always add new line on enter</value>
+  </data>
+  <data name="Always_include_snippets" xml:space="preserve">
+    <value>Always include snippets</value>
+  </data>
+  <data name="Default" xml:space="preserve">
+    <value>Default</value>
+  </data>
+  <data name="Include_snippets_when_Tab_is_typed_after_an_identifier" xml:space="preserve">
+    <value>Include snippets when Tab is typed after an identifier</value>
+  </data>
+  <data name="Never_add_new_line_on_enter" xml:space="preserve">
+    <value>Never add new line on enter</value>
+  </data>
+  <data name="Never_include_snippets" xml:space="preserve">
+    <value>Never include snippets</value>
+  </data>
+  <data name="Only_add_new_line_on_enter_after_end_of_fully_typed_word" xml:space="preserve">
+    <value>Only add new line on enter after end of fully typed word</value>
+  </data>
 </root>