You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is update to the latest version of MSBuild.StructuredLogger, that contains the forward compatibility reading support.
The initial MSBuild change to forward compatible logs reading is breaking (log data format needs to be adjusted in order to allow forward compatibile reading for the future) - hence updating the reading code ahead of MSBuild pushing the updated version of binlog writing (dotnet/msbuild#9307) is advisable.
The failing test (Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpClassification.SemanticClassification) seem to be quite unstable - should it be disabled untill fixed?
@genlu is the Roslyn.VisualStudio.IntegrationTests.CSharp.CSharpClassification.SemanticClassification being looked on?
I was hoping to get this PR merged soon so that we can proceeding with inserting the msbuild change in .NET9 P1
@JanKrivanek The failing leg can be ignored at the moment; I think it might have only triggered due to the other /azp command that was given -- this is fine to merge assuming you're ready.
Area-InfrastructureCommunityThe pull request was submitted by a contributor who is not a Microsoft employee.untriagedIssues and PRs which have not yet been triaged by a lead
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ghost
added
Area-Infrastructure
untriaged
FYI @KirillOsenkov
Context
This is update to the latest version of MSBuild.StructuredLogger, that contains the forward compatibility reading support.
The initial MSBuild change to forward compatible logs reading is breaking (log data format needs to be adjusted in order to allow forward compatibile reading for the future) - hence updating the reading code ahead of MSBuild pushing the updated version of binlog writing (dotnet/msbuild#9307) is advisable.