Make CodeAction.NestedActions public #71327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
requested review from
333fred,
dibarbet and
a team
as code owners
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Dec 18, 2023
| @@ -27,7 +27,7 @@ public abstract partial class MultipleCodeStyleOptionConfigurationTests : Abstra | |||
| protected override ImmutableArray<CodeAction> MassageActions(ImmutableArray<CodeAction> actions) | |||
| { | |||
| Assert.Single(actions); | |||
| var nestedActionForOptionIndex = ((AbstractConfigurationActionWithNestedActions)actions[0]).NestedCodeActions[OptionIndex]; | |||
| var nestedActionForOptionIndex = ((AbstractConfigurationActionWithNestedActions)actions[0]).NestedActions[OptionIndex]; | |||
There was a problem hiding this comment.
renamed property to match parameter used to actually provided nested actions.
CyrusNajmabadi
commented
Dec 18, 2023
| /// nested options with less steps. To create a <see cref="CodeAction"/> with nested actions, use <see | ||
| /// cref="Create(string, ImmutableArray{CodeAction}, bool)"/>. | ||
| /// </summary> | ||
| public virtual bool IsInlinable => false; |
There was a problem hiding this comment.
this is part and parcel of NestedActions (and is also part of the Create method).
|
@dibarbet ptal |
sharwell
reviewed
Dec 18, 2023
333fred
reviewed
Dec 18, 2023
3 tasks
dibarbet
approved these changes
Dec 18, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71050