Skip to content

Improve codegen for concatenation of string and char #70971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DoctorKrolic wants to merge 37 commits into from
Closed

Improve codegen for concatenation of string and char #70971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
1e72311
Move calling `ToString` on chars to a later step
DoctorKrolic Nov 26, 2023
8dada13
Optimize for 2 arguments
DoctorKrolic Nov 26, 2023
f64f3e2
Optimize for 3 arguments
DoctorKrolic Nov 26, 2023
e5f44d7
Fix nullability warnings
DoctorKrolic Nov 27, 2023
6a37e8a
Add assert
DoctorKrolic Nov 27, 2023
cde7014
Optimize for 4 arguments
DoctorKrolic Nov 27, 2023
c9f6901
Simplify existing tests
DoctorKrolic Nov 27, 2023
41ee64d
Add test with 5 arguments
DoctorKrolic Nov 27, 2023
22f4003
Adjust well-known members tests
DoctorKrolic Nov 27, 2023
a1f6d0f
Correct codegen when value cannot be passed by reference
DoctorKrolic Nov 28, 2023
e49f5e8
Run verification only on runtime that actually supports it
DoctorKrolic Nov 28, 2023
2394019
Tweak input a little bit
DoctorKrolic Nov 28, 2023
b779f40
Semicolon
DoctorKrolic Nov 29, 2023
1040b0c
Doc & name
DoctorKrolic Nov 29, 2023
011de2e
Simplify
DoctorKrolic Dec 1, 2023
bfc19db
Put comments inside blocks
DoctorKrolic Dec 1, 2023
b6af8cb
Rename
DoctorKrolic Dec 1, 2023
efd6e93
Simplify
DoctorKrolic Dec 1, 2023
02e5618
Fix
DoctorKrolic Dec 1, 2023
fdf6877
Renames
DoctorKrolic Dec 5, 2023
17a86ed
Add side effect tests
DoctorKrolic Dec 9, 2023
b9d19ca
Left over renames
DoctorKrolic Dec 14, 2023
5e887db
Scope temp locals to the whole `Concat` call
DoctorKrolic Dec 23, 2023
09f41e0
Directly pass by reference only none-ref parameters and locals
DoctorKrolic Dec 23, 2023
b8c1e08
Remove false assert
DoctorKrolic Dec 23, 2023
f84c969
Add pattern condition
DoctorKrolic Dec 23, 2023
0ba2071
Merge branch 'dotnet:main' into concat-string-char
DoctorKrolic Dec 24, 2023
67b4ddf
Move concat tests
DoctorKrolic Jan 3, 2024
688d98b
Rename
DoctorKrolic Jan 5, 2024
a35011e
Use explicit types
DoctorKrolic Jan 5, 2024
01ede3a
Named arguments
DoctorKrolic Jan 5, 2024
5df27cc
Capacity work
DoctorKrolic Jan 5, 2024
fe514d5
Assert and comment
DoctorKrolic Jan 5, 2024
75b4e30
Use sequence helpers
DoctorKrolic Jan 9, 2024
12aaf61
Direct references aren't save
DoctorKrolic Jan 9, 2024
594010b
Revert
DoctorKrolic Jan 9, 2024
227a687
Revert
DoctorKrolic Jan 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
425 changes: 366 additions & 59 deletions src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter_StringConcat.cs
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions src/Compilers/CSharp/Portable/Symbols/TypeSymbolExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
using System.Collections.Immutable;
using System.Diagnostics;
using System.Diagnostics.CodeAnalysis;
using System.Text;
using Microsoft.CodeAnalysis.PooledObjects;
using Roslyn.Utilities;

Expand Down Expand Up @@ -1345,7 +1344,7 @@ internal static bool IsSpanChar(this TypeSymbol type)
&& arguments[0].SpecialType == SpecialType.System_Char;
}

internal static bool IsReadOnlySpanChar(this TypeSymbol type)
internal static bool IsReadOnlySpanChar(this TypeSymbol? type)
{
return type is NamedTypeSymbol
{
Expand Down
Loading