Address additional restore changes feedback #70633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
jasonmalinowski
approved these changes
Oct 30, 2023
...soft.CodeAnalysis.LanguageServer/LanguageServer/Handler/Restore/RestorableProjectsHandler.cs
Outdated
Show resolved
Hide resolved
| @@ -49,13 +49,18 @@ private async Task RestoreAsync(ImmutableArray<string> pathsToRestore, BufferedP | |||
| { | |||
| foreach (var path in pathsToRestore) | |||
| { | |||
| var arguments = $"restore \"{path}\""; | |||
| var arguments = new string[] { "restore", path }; | |||
There was a problem hiding this comment.
Didn't want to inline with collection expressions here?
There was a problem hiding this comment.
There appear to be a bunch of formatting issues with collection expressions. Every time I try to use them I get formatting warnings (even with 'correct' formatting). I'll file a bug on that one sec.
src/Features/LanguageServer/ProtocolUnitTests/Hover/HoverTests.cs
Outdated
Show resolved
Hide resolved
dibarbet
force-pushed
the
restore_feedback
branch
2 times, most recently
from
db6d407 to
97426fc
Compare
dibarbet
force-pushed
the
restore_feedback
branch
from
97426fc to
a64ba7b
Compare
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing post merge feedback on #70588