Fix PullDiagnosticCategories to DiagnosticKind mapping in DocumentPullDiagnosticHandler #70068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lDiagnosticHandler Fixes dotnet/fsharp#15972
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
mavasani
commented
Sep 22, 2023
| @@ -82,7 +82,7 @@ protected override DiagnosticTag[] ConvertTags(DiagnosticData diagnosticData) | |||
| { | |||
| PullDiagnosticCategories.DocumentCompilerSyntax => DiagnosticKind.CompilerSyntax, | |||
| PullDiagnosticCategories.DocumentCompilerSemantic => DiagnosticKind.CompilerSemantic, | |||
| PullDiagnosticCategories.DocumentAnalyzerSyntax => DiagnosticKind.AnalyzerSemantic, | |||
| PullDiagnosticCategories.DocumentAnalyzerSyntax => DiagnosticKind.AnalyzerSyntax, | |||
There was a problem hiding this comment.
This is the only product change in the PR
|
Tagging @0101 |
CyrusNajmabadi
approved these changes
Sep 22, 2023
dibarbet
approved these changes
Sep 22, 2023
| @@ -302,20 +302,20 @@ protected static LSP.TextEdit GenerateTextEdit(string newText, int startLine, in | |||
| private protected static CodeActionResolveData CreateCodeActionResolveData(string uniqueIdentifier, LSP.Location location, IEnumerable<string>? customTags = null) | |||
| => new(uniqueIdentifier, customTags.ToImmutableArrayOrEmpty(), location.Range, CreateTextDocumentIdentifier(location.Uri)); | |||
|
|
|||
| private protected Task<TestLspServer> CreateTestLspServerAsync(string markup, bool mutatingLspWorkspace, LSP.ClientCapabilities clientCapabilities, bool callInitialized = true) | |||
| => CreateTestLspServerAsync(new string[] { markup }, LanguageNames.CSharp, mutatingLspWorkspace, new InitializationOptions { ClientCapabilities = clientCapabilities, CallInitialized = callInitialized }); | |||
| private protected Task<TestLspServer> CreateTestLspServerAsync(string markup, bool mutatingLspWorkspace, LSP.ClientCapabilities clientCapabilities, bool callInitialized = true, IEnumerable<DiagnosticAnalyzer>? additionalAnalyzers = null) | |||
There was a problem hiding this comment.
should put additionalAnalyzers in initializationOptions - that type was created because we kept adding more and more optional params
There was a problem hiding this comment.
@dibarbet - sorry I had enabled auto-merge for the PR. Let me address this in a follow-up PR.
ghost
added this to the 
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Sep 26, 2023
Address feedback from dotnet#70068 (comment) and move `AdditionalAnalyzers` to `InitializationOptions` for LSP pull diagnostics tests
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Sep 26, 2023
Address feedback from dotnet#70068 (comment) and move `AdditionalAnalyzers` to `InitializationOptions` for LSP pull diagnostics tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/fsharp#15972