Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure tuple conversions involved into a tuple binary operator are properly lowered. #69934

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Ensure tuple conversions involved into a tuple binary operator are properly lowered. #69934

merged 1 commit into from
Sep 14, 2023

Conversation

AlekseyTs
Copy link
Contributor

Fixes #66265.

@AlekseyTs AlekseyTs requested a review from jcouv September 13, 2023 18:03
@AlekseyTs AlekseyTs requested a review from a team as a code owner September 13, 2023 18:03
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Sep 13, 2023
@jcouv jcouv self-assigned this Sep 13, 2023
jcouv
jcouv approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@RikkiGibson RikkiGibson self-assigned this Sep 13, 2023
@AlekseyTs AlekseyTs merged commit 819625f into dotnet:main Sep 14, 2023
25 checks passed
@ghost ghost added this to the Next milestone Sep 14, 2023
@allisonchou allisonchou mentioned this pull request Sep 18, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

@RikkiGibson RikkiGibson

@jcouv jcouv

Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P3
Development

Successfully merging this pull request may close these issues.

Internal Compiler Error for ExplicitTuple conversion in CodeGen/Emit
4 participants
@AlekseyTs @RikkiGibson @jcouv @Cosifne