Ensure Endfilter basic block is preserved even if technically unreachable. #69922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
untriaged
|
@dotnet/roslyn-compiler Please review |
1 similar comment
|
@dotnet/roslyn-compiler Please review |
RikkiGibson
approved these changes
Sep 13, 2023
|
|
||
| static void M3() | ||
| { | ||
| System.Console.Write("M2"); |
There was a problem hiding this comment.
nit: The method name in this call doesn't match the containing method. Consider removing the call if it is not used by the test. #Resolved
There was a problem hiding this comment.
Suggested change
| System.Console.Write("M2"); | |
| System.Console.Write("M3"); |
jjonescz
reviewed
Sep 14, 2023
|
|
||
| static void M3() | ||
| { | ||
| System.Console.Write("M2"); |
There was a problem hiding this comment.
Suggested change
| System.Console.Write("M2"); | |
| System.Console.Write("M3"); |
| var verifier = CompileAndVerify(source, options: TestOptions.ReleaseExe, expectedOutput: "M1M4M1M2Catch", | ||
| // False PEVerify failure: | ||
| // PEVerify failed for assembly | ||
| // [ : C::M][mdToken=0x6000004][offset 0x0000000E] Stack not empty when leaving an exception filter. |
There was a problem hiding this comment.
I think the PEVerify failures can be verified programmatically by something like Verification.FailsPEVerify with { PEVerifyMessage = "..." }. #Resolved
jjonescz
approved these changes
Sep 14, 2023
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67494.