Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colorize unbound partial identifier as a keyword #69877

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Colorize unbound partial identifier as a keyword #69877

merged 2 commits into from
Sep 14, 2023

Conversation

DoctorKrolic
Copy link
Contributor

Noticed while working at #69874

The change is pretty much the same as #60558

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner September 11, 2023 06:58
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 11, 2023
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Sep 11, 2023
@build-analysis build-analysis bot mentioned this pull request Sep 11, 2023
Open
3 tasks
@DoctorKrolic
Copy link
Contributor Author

Can I have a review here please?

@CyrusNajmabadi
Copy link
Member

Thanks!

@CyrusNajmabadi CyrusNajmabadi merged commit 9585e90 into dotnet:main Sep 14, 2023
24 checks passed
@ghost ghost added this to the Next milestone Sep 14, 2023
@DoctorKrolic DoctorKrolic deleted the partial-colorization branch September 14, 2023 20:11
@allisonchou allisonchou mentioned this pull request Sep 18, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@Youssef1313 Youssef1313 Awaiting requested review from Youssef1313

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P3
Development

Successfully merging this pull request may close these issues.
4 participants
@DoctorKrolic @CyrusNajmabadi @Youssef1313 @Cosifne