Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix folding range bug in C# extension #69817

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Fix folding range bug in C# extension #69817

merged 3 commits into from
Sep 13, 2023

Conversation

akhera99
Copy link
Member

@akhera99 akhera99 commented Sep 5, 2023

@akhera99 akhera99 requested a review from dibarbet September 5, 2023 18:26
@akhera99 akhera99 requested a review from a team as a code owner September 5, 2023 18:26
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Sep 5, 2023
genlu
genlu reviewed Sep 11, 2023
View reviewed changes
Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you pls also add a test to validate the returned FoldingRange[]?

@akhera99 akhera99 enabled auto-merge (squash) September 13, 2023 20:55
@akhera99 akhera99 merged commit 0d61377 into dotnet:main Sep 13, 2023
24 checks passed
@ghost ghost added this to the Next milestone Sep 13, 2023
@allisonchou allisonchou mentioned this pull request Sep 18, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genlu genlu genlu left review comments

@dibarbet dibarbet dibarbet approved these changes

Assignees
No one assigned
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.8 P3
Development

Successfully merging this pull request may close these issues.

Fold All Regions no longer works with new language server
4 participants
@akhera99 @genlu @dibarbet @Cosifne