-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update License.txt to MIT #68942
Update License.txt to MIT #68942
Conversation
Oops. Not sure what happened here. This should have been MIT from the start. (it was all created from originally MIT licensed roslyn code).
From memory, this was using that license because it uses MS.VS.LSP.Protocol, which has that license. I'm not a lawyer though, so no idea if that means this is an acceptable change or not 😛 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there shouldn't be any license file in this project.
This file and all these properties should be deleted:
<PackageLicenseExpression></PackageLicenseExpression>
<PackageLicenseFile>License.txt</PackageLicenseFile>
<ItemGroup>
<None Include="License.txt" PackagePath="" Pack="true" />
</ItemGroup>
The package will then automatically have the same license as other packages in Roslyn.
That makes sense. I'll change that. |
Yeah, that's an oopsy. That license either needs to change, or we need to just stop using it and read/write json directly (or find a helper lib with the right license). Annoying, but doable |
I can't find any reference from this project to something named MS.VS.LSP.Protocol. The change suggested by @tmat appears to be the easy solution. |
Oops. Not sure what happened here. This should have been MIT from the start. (it was all created from originally MIT licensed roslyn code).
Fixes #68463