Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update License.txt to MIT #68942

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Update License.txt to MIT #68942

merged 2 commits into from
Jul 10, 2023

Conversation

CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Jul 9, 2023

Oops. Not sure what happened here. This should have been MIT from the start. (it was all created from originally MIT licensed roslyn code).

Fixes #68463

Oops.  Not sure what happened here.  This should have been MIT from the start.  (it was all created from originally MIT licensed roslyn code).
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner July 9, 2023 16:56
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 9, 2023
@CyrusNajmabadi CyrusNajmabadi requested a review from arunchndr July 9, 2023 16:57
@davidwengier
Copy link
Member

Not sure what happened here

From memory, this was using that license because it uses MS.VS.LSP.Protocol, which has that license. I'm not a lawyer though, so no idea if that means this is an acceptable change or not 😛

tmat
tmat previously requested changes Jul 10, 2023
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, there shouldn't be any license file in this project.

This file and all these properties should be deleted:

<PackageLicenseExpression></PackageLicenseExpression>
<PackageLicenseFile>License.txt</PackageLicenseFile>


  <ItemGroup>
    <None Include="License.txt" PackagePath="" Pack="true" />
  </ItemGroup>

The package will then automatically have the same license as other packages in Roslyn.

@CyrusNajmabadi
Copy link
Member Author

That makes sense. I'll change that.

@CyrusNajmabadi
Copy link
Member Author

From memory, this was using that license because it uses MS.VS.LSP.Protocol, which has that license.

Yeah, that's an oopsy. That license either needs to change, or we need to just stop using it and read/write json directly (or find a helper lib with the right license). Annoying, but doable

@sharwell
Copy link
Member

From memory, this was using that license because it uses MS.VS.LSP.Protocol, which has that license.

I can't find any reference from this project to something named MS.VS.LSP.Protocol. The change suggested by @tmat appears to be the easy solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider license for Microsoft.CommonLanguageServerProtocol.Framework and related projects
6 participants