Small perf improvement during code action computation. #68631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Changed AbstractCodeActionComputer.GetIndentationAfter to only create two snapshots per invocation. 2) Slight optimization around codeaction computation in parameter list context as there are scenarios I was hitting where neither _singleIndentationTrivia nor _braceIndentationTrivia were used during ComputeWrappingGroupsAsync.
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
approved these changes
Jun 15, 2023
mavasani
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed AbstractCodeActionComputer.GetIndentationAfter to only create two snapshots per invocation.
Slight optimization around codeaction computation in parameter list context as there are scenarios I was hitting where neither _singleIndentationTrivia nor _braceIndentationTrivia were used during ComputeWrappingGroupsAsync.