Skip to content

Move off of recursion when determining pp-directive information for a file. #68460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 7, 2023
Merged

Move off of recursion when determining pp-directive information for a file. #68460

merged 13 commits into from
Jun 7, 2023

Conversation

@CyrusNajmabadi
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi commented Jun 6, 2023 •
edited by Pilchie
Loading

Fixes AB#1823533

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner June 6, 2023 21:18
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 6, 2023
CyrusNajmabadi
CyrusNajmabadi commented Jun 6, 2023
View reviewed changes
...kspaces/SharedUtilitiesAndExtensions/Compiler/CSharp/Extensions/DirectiveSyntaxExtensions.cs Outdated
{
var root = node.GetAbsoluteRoot();
var info = s_rootToDirectiveInfo.GetValue(root, r =>
var directiveMap = new Dictionary<DirectiveTriviaSyntax, DirectiveTriviaSyntax?>(
Copy link
Member Author

@CyrusNajmabadi CyrusNajmabadi Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all the logic from the walker, just moved into inline state in this method.

genlu
genlu approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge June 7, 2023 17:59
@CyrusNajmabadi CyrusNajmabadi merged commit 92d59e5 into dotnet:main Jun 7, 2023
@ghost ghost added this to the Next milestone Jun 7, 2023
@CyrusNajmabadi CyrusNajmabadi deleted the norecurse branch June 7, 2023 22:34
@allisonchou allisonchou mentioned this pull request Jun 16, 2023
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.7 P3 Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genlu genlu genlu approved these changes

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.7 P3

Development

Successfully merging this pull request may close these issues.

3 participants

@CyrusNajmabadi @genlu @RikkiGibson