Skip to content

Conversation

@333fred
Copy link
Member

@333fred 333fred commented May 16, 2023

No description provided.

@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead Needs API Review Needs to be reviewed by the API review council labels May 16, 2023
@ghost
Copy link

ghost commented May 16, 2023

This PR modifies public API files. Please follow the instructions at https://github.com/dotnet/roslyn/blob/main/docs/contributing/API%20Review%20Process.md for ensuring all public APIs are reviewed before merging.

@333fred
Copy link
Member Author

333fred commented May 18, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@333fred 333fred marked this pull request as ready for review May 19, 2023 00:40
@333fred 333fred requested review from a team as code owners May 19, 2023 00:40
@333fred 333fred enabled auto-merge (squash) May 19, 2023 00:41
Microsoft.CodeAnalysis.Editing.SyntaxGenerator.AttributeArgument(Microsoft.CodeAnalysis.SyntaxNode expression) -> Microsoft.CodeAnalysis.SyntaxNode
Microsoft.CodeAnalysis.Editing.SyntaxGenerator.CastExpression(Microsoft.CodeAnalysis.ITypeSymbol type, Microsoft.CodeAnalysis.SyntaxNode expression) -> Microsoft.CodeAnalysis.SyntaxNode
Microsoft.CodeAnalysis.Editing.SyntaxGenerator.CatchClause(Microsoft.CodeAnalysis.ITypeSymbol type, string identifier, System.Collections.Generic.IEnumerable<Microsoft.CodeAnalysis.SyntaxNode> statements) -> Microsoft.CodeAnalysis.SyntaxNode
Microsoft.CodeAnalysis.Editing.SyntaxGenerator.ClassDeclaration(string name, System.Collections.Generic.IEnumerable<string> typeParameters = null, Microsoft.CodeAnalysis.Accessibility accessibility = Microsoft.CodeAnalysis.Accessibility.NotApplicable, Microsoft.CodeAnalysis.Editing.DeclarationModifiers modifiers = default(Microsoft.CodeAnalysis.Editing.DeclarationModifiers), Microsoft.CodeAnalysis.SyntaxNode baseType = null, System.Collections.Generic.IEnumerable<Microsoft.CodeAnalysis.SyntaxNode> interfaceTypes = null, System.Collections.Generic.IEnumerable<Microsoft.CodeAnalysis.SyntaxNode> members = null) -> Microsoft.CodeAnalysis.SyntaxNode
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some of these just moved. Not sure if that's an issue

@333fred 333fred merged commit 6aaac35 into dotnet:release/dev17.6 May 19, 2023
333fred added a commit that referenced this pull request May 20, 2023
…elease/dev17.7-to-main

* upstream/release/dev17.7: (44 commits)
  Revert all the changes flow from 17.5
  Mark 17.6 APIs as shipped (#68221)
  Check for 17.6 for LOC
  Update compiler version
  Update how we are getting active document filename
  Remove unused test method
  Start build after we have hooked build events.
  Return E_NOTIMPL
  Lines are zero based.
  Remove unnecessary delegate
  Remove unused using directives
  Remove unused events and method implementations
  Remove unused interface implementation
  Listen to build manager events to know when build is complete
  Remove unused test method
  Start build after we have hooked build events.
  Return E_NOTIMPL
  Lines are zero based.
  Remove unnecessary delegate
  Remove unused using directives
  ...
@333fred 333fred deleted the mark-shipped branch May 22, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Needs API Review Needs to be reviewed by the API review council untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants