Fix a bug in AnalyzerManager.GetCompilationAnalysisScopeCoreAsync - #680
Merged
Conversation
…use the GetOrAdd overload that takes a Func rather then value. This should avoid spawing multiple tasks to execute CompilationStartAction for an analyzer, and fix the VS responsiveness issues we have been seeing in DeclarePublicAPIAnalyzer.
Contributor
|
👍 |
Contributor
|
For context, this is causing us to spin up lots of Tasks that end up stuck in the DeclarePublicAPI analyzer's compilation start action while reading PublicAPI.txt. This saturates the thread pool while editing files in Roslyn.sln and kills VS responsiveness. I'm making a separate change to check the CancellationToken more aggressively in the analyzer itself, but I'm not convinced that will actually help in this case. |
Contributor
|
👍 |
mavasani
added a commit
that referenced
this pull request
Feb 19, 2015
Fix a bug in AnalyzerManager.GetCompilationAnalysisScopeCoreAsync
dibarbet
pushed a commit
that referenced
this pull request
Aug 18, 2026
Fully support additional projects
This was referenced Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in AnalyzerManager.GetCompilationAnalysisScopeCoreAsync to use the GetOrAdd overload that takes a Func rather then value. This should avoid spawning multiple tasks to execute CompilationStartAction for an analyzer, and fix the VS responsiveness issues we have been seeing in #610
@tmeschter @heejaechang @JohnHamby can you please take a look?
I guess we should address #664 as soon as possible.