Avoid accessing DocData prior to document initialization #67978
Conversation
ghost
added
Area-IDE
untriaged
| (int)frameType == (int)__WindowFrameTypeFlags.WINDOWFRAMETYPE_Document) | ||
| { | ||
| TrackNewActiveWindowFrame(frame); | ||
| var runningDocumentTable = ThreadingContext.JoinableTaskFactory.Run(() => GetRunningDocumentTableAsync(ThreadingContext.DisposalToken).AsTask()); |
There was a problem hiding this comment.
Won't this just block here instead?
There was a problem hiding this comment.
➡️ In general, no. This method returns immediately in all but the first invocation, and the first invocation should come through the other path. In the event it doesn't it'll wait here for the service to be initialized.
There was a problem hiding this comment.
I'm not especially worried here because in the off chance there is a problem, it'll be an item on the call stack in RPS results.
| { | ||
| if (docData is IVsTextBuffer bufferAdapter) | ||
| { | ||
| TextBuffer = _documentTracker._editorAdaptersFactoryService.GetDocumentBuffer(bufferAdapter); |
There was a problem hiding this comment.
Just want to make sure, is our cleanup code resilient to this not being her
There was a problem hiding this comment.
Most of the stack here is null annotated and everything I saw had null checks in place. To outside code, this just shows up as the DocumentId being null, which is also the case any time a non-Roslyn document has focus.
4 participants
This change builds off observations and instructions provided by @RadwanFaci.
Supersedes #67976