Skip to content

Call PrimaryDependency getter once in PENamedTypeSymbol.GetUseSiteInfo #67927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

Call PrimaryDependency getter once in PENamedTypeSymbol.GetUseSiteInfo #67927

merged 1 commit into from
Apr 26, 2023

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Apr 22, 2023

Not sure how much improvement is this

image

image

@Youssef1313 Youssef1313 requested a review from a team as a code owner April 22, 2023 12:24
@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Apr 22, 2023
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 22, 2023

Is there a type called PETypeSymbol?

AlekseyTs
AlekseyTs approved these changes Apr 22, 2023
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@AlekseyTs AlekseyTs removed the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 22, 2023
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 22, 2023

@dotnet/roslyn-compiler For a second review on a small community PR.

@Youssef1313 Youssef1313 changed the title Call PrimaryDependency getter once in PETypeSymbol.GetUseSiteInfo Call PrimaryDependency getter once in PENamedTypeSymbol.GetUseSiteInfo Apr 22, 2023
@AlekseyTs AlekseyTs merged commit 492e261 into dotnet:main Apr 26, 2023
@ghost ghost added this to the Next milestone Apr 26, 2023
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 26, 2023

@Youssef1313 Thanks for the contribution

@Youssef1313 Youssef1313 deleted the patch-46 branch April 26, 2023 17:05
@allisonchou allisonchou mentioned this pull request May 2, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjonescz jjonescz jjonescz approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees

No one assigned

Labels

Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

17.7 P2

Development

Successfully merging this pull request may close these issues.

4 participants

@Youssef1313 @AlekseyTs @jjonescz @Cosifne