Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnC: Implements support for generic type/method updates #67918

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

tmat
Copy link
Member

@tmat tmat commented Apr 21, 2023

Introduces the following capabilities that runtimes can now implement:

/// <summary>
/// Adding a static or instance method, property or event to an existing type (without backing fields), such that the method and/or the type are generic.
/// </summary>
GenericAddMethodToExistingType = 1 << 7,

/// <summary>
/// Updating an existing static or instance method, property or event (without backing fields) that is generic and/or contained in a generic type. 
/// </summary>
GenericUpdateMethod = 1 << 8,

/// <summary>
/// Adding a static or instance field to an existing generic type.
/// </summary>
GenericAddFieldToExistingType = 1 << 9,

Updates rude edit reporting accordingly.

Related: dotnet/runtime#85177

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 21, 2023
@tmat tmat marked this pull request as ready for review April 21, 2023 18:55
@tmat tmat requested a review from a team as a code owner April 21, 2023 18:55
@tmat
Copy link
Member Author

tmat commented Apr 21, 2023

@davidwengier PTAL
@phil-allen-msft FYI

@tmat tmat merged commit cbf5e54 into dotnet:main Apr 24, 2023
@tmat tmat deleted the enc-generics branch April 24, 2023 19:35
@ghost ghost added this to the Next milestone Apr 24, 2023
@dibarbet dibarbet modified the milestones: Next, 17.7 P1 Apr 25, 2023
lambdageek added a commit to dotnet/hotreload-utils that referenced this pull request May 1, 2023
dotnet-maestro bot added a commit to dotnet/hotreload-utils that referenced this pull request May 1, 2023
[main] Update dependencies from dotnet/roslyn


 - Merge branch 'main' into darc-main-90db018b-2fbf-4f60-a592-5d2cd5d47371

 - Add new EnC capabilities to enum

from dotnet/roslyn#67918
@tmat tmat mentioned this pull request Oct 4, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Interactive-EnC untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants