Skip to content

Always include syntactic classifications in semantic response #67625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2023
Merged

Always include syntactic classifications in semantic response #67625

merged 1 commit into from
Apr 3, 2023

Conversation

@dibarbet
Copy link
Member

@dibarbet dibarbet commented Apr 3, 2023 •
edited by arunchndr
Loading

@dibarbet dibarbet requested a review from CyrusNajmabadi April 3, 2023 22:01
@dibarbet dibarbet requested a review from a team as a code owner April 3, 2023 22:01
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 3, 2023
dibarbet
dibarbet commented Apr 3, 2023
View reviewed changes
src/Features/LanguageServer/ProtocolUnitTests/SemanticTokens/SemanticTokensRangeTests.cs
}

[Theory, CombinatorialData]
public async Task TestGetSemanticTokensRange_FullDoc_RazorAsync(bool mutatingLspWorkspace)
Copy link
Member Author

@dibarbet dibarbet Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dupe test now that we always return

dibarbet
dibarbet commented Apr 3, 2023
View reviewed changes
src/Features/LanguageServer/ProtocolUnitTests/SemanticTokens/SemanticTokensRangeTests.cs
}

[Theory, CombinatorialData]
public async Task TestGetSemanticTokensRange_StringLiteralAsync(bool mutatingLspWorkspace)
Copy link
Member Author

@dibarbet dibarbet Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dupe test now that we always return

@dibarbet dibarbet merged commit f9bd440 into dotnet:main Apr 3, 2023
@dibarbet dibarbet deleted the include_syntactic_always branch April 3, 2023 23:09
@ghost ghost added this to the Next milestone Apr 3, 2023
@allisonchou allisonchou mentioned this pull request Apr 6, 2023
Closed
@dibarbet dibarbet modified the milestones: Next, 17.7 P1 Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

+1 more reviewer

@arunchndr arunchndr arunchndr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead

Projects

None yet

Milestone

17.7 P1

Development

Successfully merging this pull request may close these issues.

3 participants

@dibarbet @CyrusNajmabadi @arunchndr