Don't crash server if code lens cache entry does not exist #67610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
added
Area-IDE
LSP
ghost
added
the
untriaged
dibarbet
commented
Apr 1, 2023
|
|
||
| public LSP.TextDocumentIdentifier GetTextDocumentIdentifier(LSP.CodeLens request) | ||
| => GetCacheEntry(request).CacheEntry.TextDocumentIdentifier; | ||
| => GetCodeLensResolveData(request).TextDocument; |
Member
Author
There was a problem hiding this comment.
the key line that changed - instead of reading from the cache entry (which in this error scenario doesn't exist) we read from the resolve data (which comes from the request itself). The request will still throw an error, but it will happen later when an error won't take down the whole queue.
CyrusNajmabadi
approved these changes
Apr 1, 2023
5 tasks
arunchndr
approved these changes
Apr 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we're getting requested for codelens for cache entries that don't exist. This is not a full fix for the problem, but it does correct server behavior. Instead of crashing during the request context creation (which takes down the entire server), we'll throw an error in the actual handling of the request (which will not take down the entire server).
Actual fix for invalid requests TBD
This is related to AB#1778972, but doesn't fix entirely the issue (as mentioned above). But I kept running into the server crashing b/c of this today so I at least wanted to improve that part.