Avoid allocating enumerators in symbol usage analysis #67582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Mar 30, 2023
| var uniqueSymbols = PooledHashSet<ISymbol>.GetInstance(); | ||
| try | ||
| using var _ = PooledHashSet<ISymbol>.GetInstance(out var uniqueSymbols); | ||
|
|
Member
Author
There was a problem hiding this comment.
read with whitespace off.
ToddGrun
reviewed
Mar 31, 2023
| #endif | ||
|
|
||
| uniqueSymbols.AddRange(_reachingWrites.Keys); | ||
| uniqueSymbols.AddRange(other._reachingWrites.Keys); |
Contributor
Member
Author
There was a problem hiding this comment.
i'll look to see :)
Contributor
There was a problem hiding this comment.
Going to sign off per our offline conversation. If Overlaps wouldn't suffer from the same allocation issue, then it seems like uniqueSymbols isn't needed.
mavasani
added
the
Performance-Scenario-Diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes 60MB of allocs in a simple typing/lightbulb scenario. This is 1.5% of all allocs in that scenario:
After this change, this allocation is gone.