Skip to content

Use 'DoNot' instead of contraction 'Dont' in symbol names #67550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Use 'DoNot' instead of contraction 'Dont' in symbol names #67550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Analyzers/CSharp/Tests/AddInheritdoc/AddInheritdocTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public override void M() { }
[InlineData("public void {|CS1591:OtherMethod|}() { }")]
[InlineData("public void {|CS1591:M|}() { }")]
[InlineData("public new void {|CS1591:M|}() { }")]
public async Task DontOfferOnNotOverridenMethod(string methodDefintion)
public async Task DoNotOfferOnNotOverridenMethod(string methodDefintion)
{
await TestMissingAsync(
$@"
Expand Down Expand Up @@ -120,7 +120,7 @@ public void M() { }
}

[Fact]
public async Task DontOfferOnExplicitInterfaceMethod()
public async Task DoNotOfferOnExplicitInterfaceMethod()
{
await TestMissingAsync(
"""
Expand Down
2 changes: 1 addition & 1 deletion src/Analyzers/CSharp/Tests/AddParameter/AddParameterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2526,7 +2526,7 @@ public void Test() {
}

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/29061")]
public async Task TestThis_DontOfferToFixTheConstructorWithTheDiagnosticOnIt()
public async Task TestThis_DoNotOfferToFixTheConstructorWithTheDiagnosticOnIt()
{
// error CS1729: 'C' does not contain a constructor that takes 1 arguments
var code =
Expand Down
2 changes: 1 addition & 1 deletion src/Analyzers/CSharp/Tests/AliasAmbiguousType/AliasAmbiguousTypeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ void M()
}

[Fact]
public async Task TestAmbiguousClassObjectCreationGenericsDontOfferDiagnostic()
public async Task TestAmbiguousClassObjectCreationGenericsDoNotOfferDiagnostic()
{
var genericAmbiguousClassDefinition = GetAmbiguousDefinition("public class Ambiguous<T> { }");
await TestMissingAsync(@"
Expand Down
2 changes: 1 addition & 1 deletion src/Analyzers/CSharp/Tests/RemoveInKeyword/RemoveInKeywordCodeFixProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ void N(int i, string s)
}

[Fact]
public async Task TestDontRemoveInKeyword()
public async Task TestDoNotRemoveInKeyword()
{
await TestMissingInRegularAndScriptAsync(
"""
Expand Down
2 changes: 1 addition & 1 deletion src/Analyzers/VisualBasic/Tests/AddParameter/AddParameterTests.vb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,7 +1017,7 @@ End Class
End Function

<Fact, WorkItem("https://github.com/dotnet/roslyn/issues/29061")>
Public Async Function TestConstructorInitializer_DontOfferFixForConstructorWithDiagnostic() As Task
Public Async Function TestConstructorInitializer_DoNotOfferFixForConstructorWithDiagnostic() As Task
' Error BC30057: Too many arguments to 'Public Sub New()'.
Dim code =
"
Expand Down
Loading