Remove support for synchronous lightbulbs #67536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
CyrusNajmabadi
force-pushed
the
removeSyncLightbulb
branch
from
9c91f07 to
4938c6f
Compare
CyrusNajmabadi
commented
Mar 29, 2023
| internal partial class SuggestedActionsSourceProvider | ||
| { | ||
| private partial class AsyncSuggestedActionsSource : SuggestedActionsSource, IAsyncSuggestedActionsSource | ||
| private partial class SuggestedActionsSource : IAsyncSuggestedActionsSource |
Member
Author
There was a problem hiding this comment.
merged subclass into parent class (and make parent concrete/sealed).
CyrusNajmabadi
commented
Mar 29, 2023
| private partial class SuggestedActionsSource | ||
| { | ||
| protected sealed class State : IDisposable | ||
| private sealed class State : IDisposable |
Member
Author
There was a problem hiding this comment.
no subclassing. so these types and helpers became private.
sharwell
approved these changes
Mar 29, 2023
auto-merge was automatically disabled
March 29, 2023 03:14
Pull request was closed
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Mar 29, 2023
`isExplicit` flag was added in dotnet#67392 to indicate explicit user-invoked diagnostic request. However, I incorrectly set this value to `isExplicit: isBlocking` in CodeFixService. `isBlocking` flag indicates if we are executing sync lightbulb or async lightbulb, and this flag is always false for the current default async lightbulb. This PR adjusts `isExplicit` argument to be always true for `GetDiagnosticsForSpanAsync` call from `CodeFixService.StreamFixesAsync` in release/dev17.6 branch. I will create a separate PR targeting main branch that builds on top of dotnet#67536 and completely removes the `isBlocking` flag as we no longer support sync lightbulb source in main branch.
CyrusNajmabadi
pushed a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
Mar 29, 2023
`isExplicit` flag was added in dotnet#67392 to indicate explicit user-invoked diagnostic request. However, I incorrectly set this value to `isExplicit: isBlocking` in CodeFixService. `isBlocking` flag indicates if we are executing sync lightbulb or async lightbulb, and this flag is always false for the current default async lightbulb. This PR adjusts `isExplicit` argument to be always true for `GetDiagnosticsForSpanAsync` call from `CodeFixService.StreamFixesAsync` in release/dev17.6 branch. I will create a separate PR targeting main branch that builds on top of dotnet#67536 and completely removes the `isBlocking` flag as we no longer support sync lightbulb source in main branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've gone more than a full release now with async lightbulbs being on and working fine. Removing the now-legacy codepaths for synchronous lightbulbs from 17.7